8000 DDC-3467: Embeddable in inheritance currently must be protected · Issue #4277 · doctrine/orm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

DDC-3467: Embeddable in inheritance currently must be protected #4277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
doctrinebot opened this issue Dec 30, 2014 · 4 comments
Closed

DDC-3467: Embeddable in inheritance currently must be protected #4277

doctrinebot opened this issue Dec 30, 2014 · 4 comments
Assignees
@Ocramius
Labels
Bug
Milestone
2.5.5

Comments

@doctrinebot
Copy link

Jira issue originally created by user nemo64:

I have a setup similar to this one :

/****
 * @ORM\Table()
 * @ORM\Entity(readOnly=true)
 * @ORM\InheritanceType("SINGLE_TABLE")
 ****/
abstract class Planet
{
    /** ... **/
    /****
     * @var Position
     * @ORM\Embedded(class="Position")
     */
    private $position;
}

/****
 * @ORM\Entity(readOnly=true)
 ****/
class Sun extends Planet
{
}

This causes the following error:

[ReflectionException]
Property Sun::$position does not exist

This can easily be fixed by making the embeddable protected, but if I didn't miss anything, a private embed should work too.
@doctrinebot
Copy link
Author

Comment created by @Ocramius:

Can you convert this into a test case? Seems trivial to fix afterwards

@doctrinebot doctrinebot added the Bug label Dec 7, 2015
@acanimal
Copy link

Any news on this issue?

@lcobucci
Copy link
Member
lcobucci commented Jun 9, 2016

This duplicates #4097 right?
I'll work on a test for it now.

@acanimal
Copy link
acanimal commented Jun 9, 2016

@lcobucci It seems so. Thanks !!!

lcobucci added a commit to lcobucci/doctrine2 that referenced this issue Jun 9, 2016
@lcobucci
Allow the usage of embedded objects on parent classes.
1e8e42c 
The `ClassMetadataInfo` was always using the "current class" to
fetch the reflection of a property even when a field is declared
on the parent class (which causes `ReflectionProperty` to throw
an exception).

Fixes doctrine#4097 and doctrine#4277.
@lcobucci lcobucci mentioned this issue Jun 9, 2016
Closed
@Ocramius Ocramius added this to the 2.5.5 milestone Jun 19, 2016
@Ocramius Ocramius assigned Ocramius and unassigned beberlei Jun 19, 2016
Ocramius added a commit that referenced this issue Jun 19, 2016
@Ocramius
Merge branch 'fix/#5867-allow-embeddable-usage-in-inheritance-2.5' in…
aa58203 
…to 2.5

Close #5867
Close #4097
Close #4277
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ocramius Ocramius

Labels
Bug
Projects
None yet
Milestone
2.5.5
Development

No branches or pull requests
5 participants
@beberlei @Ocramius @lcobucci @acanimal @doctrinebot
0