8000 Add PHP 7 to the build matrix using polyfill by alcaeus · Pull Request #258 · doctrine/mongodb · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Nov 11, 2020. It is now read-only.

Add PHP 7 to the build matrix using polyfill #258

Merged
merged 3 commits into from
Mar 27, 2016
Merged

Add PHP 7 to the build matrix using polyfill #258

merged 3 commits into from
Mar 27, 2016

Conversation

alcaeus
Copy link
Member
@alcaeus alcaeus commented Mar 26, 2016

While composer.json has allowed installing on PHP 7 for a while (given that the ext-mongo requirement is fulfilled), there were no tests for that platform. This PR adds alcaeus/mongo-php-adapter as polyfill to the PHP 7 version of the build matrix.

Note: due to a bug with composer the build step installing the polyfill is running with the ignore-platform-reqs flag. Once this bug is fixed the flag should be removed.

Note 2: there is one test that would be failing and is skipped: mainly, it checks whether connecting/disconnecting updates the connected flag. Due to the new MongoDB driver not providing explicit connect/disconnect functionality the flag cannot be updated. Since this behavior should not cause too many problems in production I've decided to skip the test.

@alcaeus alcaeus added the task label Mar 26, 2016
@malarzm
Copy link
Member
malarzm commented Mar 26, 2016

👍

@alcaeus alcaeus merged commit 04260d4 into doctrine:1.3.x Mar 27, 2016
@alcaeus alcaeus deleted the php-7-tests branch March 27, 2016 07:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alcaeus @malarzm
0