1962 invalid port #2227
Closed
1962 invalid port #2227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please sign your commits following these rules: $ git clone -b "1962-invalid-port" git@github.com:l
8000
atiif/cli.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354376832
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
|
@GordonTheTurtle I tried adding Any suggestions? |
Signed-off-by: Latiif <llusx@outlook.com>
Signed-off-by: Latiif <llusx@outlook.com>
Signed-off-by: Latiif <llusx@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
I fixed the issue described in #1962 pertaining to invalid port passed with the flag
-p- How I did it
Following the suggestions of @thaJeztah, I checked if the flag is advanced i.e. of the form
-p target=<PORT>,publish=<PORT>and if it was a shorthand, the parsing error should be reported with an appropriate message and NOT try to parse it as advanced.- How to verify it
opts_test.go.make -f docker.Makefile test- Description for the changelog
Capture erroneous port in shorthand version of the publish flag.
- A picture of a cute animal (not mandatory but encouraged)