[enhancement] enable buildkit from daemon side #1275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
waiting on moby/moby#37593 |
cab7cec to
01b214c
Compare
Codecov Report
@@ Coverage Diff @@
## master #1275 +/- ##
==========================================
- Coverage 54.77% 54.77% -0.01%
==========================================
Files 292 292
Lines 19257 19260 +3
==========================================
+ Hits 10548
8000
10549 +1
- Misses 8055 8056 +1
- Partials 654 655 +1 |
|
Talked with @AntaresS about this PR, needs update of vendor of |
01b214c to
5d613dc
Compare
Signed-off-by: Anda Xu <anda.xu@docker.com>
ba8ab81 to
f00c470
Compare
|
@andrewhsu dependency conflicts resolved. |
f00c470 to
5783b38
Compare
tiborvass
requested changes
Aug 20, 2018
ff1f8c8 to
8d94444
Compare
Signed-off-by: Anda Xu <anda.xu@docker.com>
8d94444 to
acf43b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR needs to have latest of
github.com/docker/dockervendored into thedocker/clicodebase to make use of the feature flags.- What I did
--buildkitoption to enable buildkit in daemon [enhancement] add optional (features) fields in daemon.json to enable buildkit moby/moby#37593.DOCKER_BUILDKITenv var setup from client host.- How I did it
- How to verify it
Now with "experimental" and "buildkit" enabled on the daemon side,
docker buildwill use buildkit as builder- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)