8000 mount /var/run/docker.sock for --use-api-socket by ndeloof · Pull Request #6157 · docker/cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

mount /var/run/docker.sock for --use-api-socket #6157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2025
Merged

mount /var/run/docker.sock for --use-api-socket #6157

merged 1 commit into from
Jul 1, 2025
+4 −5

Conversation

ndeloof
Copy link
Contributor
@ndeloof ndeloof commented Jun 30, 2025 •
edited by vvoland
Loading

- What I did

s.dockerCli.DockerEndpoint().Host returns the engine URL as seen by client, which is only relevant an Unix/MacOS with a local docker engine. Waiting for engine to expose this information in some API, or implement this feature on its own, hard-coding /var/run/docker.sock offer a more reliable path for engine socket to be mounted in container, while not 100% guaranteed to succeed.

- How I did it

hard-coded path

- How to verify it

- Human readable description for the release notes

Fix `--use-api-socket` not working correctly when targeting a remote daemon.

- A picture of a cute animal (not mandatory but encouraged)

@ndeloof ndeloof mentioned this pull request Jun 30, 2025
Merged
@codecov-commenter
Copy link
codecov-commenter commented Jun 30, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 54.83%. Comparing base (7cbee73) to head (2ba7cb8).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #6157   +/-   ##
=======================================
  Coverage   54.82%   54.83%           
=======================================
  Files         364      364           
  Lines       30470    30467    -3     
=======================================
  Hits        16706    16706           
+ Misses      12789    12786    -3     
  Partials      975      975
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ndeloof ndeloof force-pushed the use_api_socket branch 3 times, most recently from 2bde860 to 163f4c6 Compare June 30, 2025 10:36
@ndeloof
mount /var/run/docker.sock for --use-api-socket
2ba7cb8 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
thaJeztah
thaJeztah approved these changes Jun 30, 2025
View reviewed changes
Copy link
Member
@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah added this to the 28.3.1 milestone Jun 30, 2025
@thaJeztah thaJeztah merged commit 74a896f into docker:master Jul 1, 2025
87 checks passed
@thaJeztah thaJeztah modified the milestones: 28.3.1, 28.3.2 Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes

Assignees
No one assigned
Labels
area/daemon impact/changelog kind/bugfix PR's that fix bugs
Projects
None yet
Milestone
28.3.2
Development

Successfully merging this pull request may close these issues.
4 participants
@ndeloof @codecov-commenter @thaJeztah @vvoland
306E
0