docs: run: Drop unnecessary command options of the --workdir example #6050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `-i` and `-t` options are not needed, as the `pwd` command does not require a TTY nor an interactive session. Drop them to simplify the example and avoid causing unnecessary confusion to the reader. Signed-off-by: 林博仁(Buo-ren Lin) <buo.ren.lin@gmail.com>
|
The DCO check failed merely due to the different author name style expected by GitHub vs. my personal preference:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6050 +/- ##
=======================================
Coverage 58.99% 58.99%
=======================================
Files 358 358
Lines 30004 30004
=======================================
Hits 17700 17700
Misses 11323 11323
Partials 981 981 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
The
-iand-toptions are not needed, as thepwdcommand does not require a TTY nor an interactive session.- How I did it
Drop them to simplify the example and avoid causing unnecessary confusion to the reader.
- How to verify it
Build the docs and verify the rendered result.