buildx(build): always register as secret the value passed as build secret string #645
8000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cret string Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
884ab02 to
6ddae4e
Compare
crazy-max
commented
Apr 7, 2025
| @@ -310,13 +319,16 @@ export class Build { | |||
| return false; | |||
| } | |||
|
|
|||
| private static parseSecretKvp(kvp: string): [string, string] { | |||
| public static parseSecretKvp(kvp: string, redact?: boolean): [string, string] { | |||
8000
There was a problem hiding this comment.
Make this method public so we can use it in build-push-action repo to redact the secrets input for build summary case.
There was a problem hiding this comment.
Opened docker/build-push-action#1351 as follow-up
|
Rucellmai61 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
docker/build-push-actiona build secret can be passed directly in the workflow using key/value pair with thesecretsinput:- name: Build and push uses: docker/build-push-action@v6 with: push: true tags: user/app:latest secrets: | GIT_AUTH_TOKEN=${{ secrets.MYTOKEN }}Registered GitHub Secrets within the repository are already redacted in the logs but some users might pass them as plain text like:
- name: Build and push uses: docker/build-push-action@v6 with: push: true tags: user/app:latest secrets: | MYSECRET=fooEven if this value is already leaked within the workflow we can at least always register as secret the value passed as build secret string here.