8000 Add tests for list boxed expressions by opatrascoiu · Pull Request #694 · dmn-tck/tck · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add tests for list boxed expressions #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

opatrascoiu
Copy link
Contributor

No description provided.

@opatrascoiu
Copy link
Contributor Author

@SimonRinguette You were right about the expected values for string(null). I made the changes.

Please review

@StrayAlien
Copy link
Contributor
A838 StrayAlien commented Jun 10, 2025

@opatrascoiu - I think you meant to have the explicit typerefs on the list elements of _D20690B7-C133-41B0-81A1-50532E5EE167 as strings? You have them there as stringlist type.

In a "typesafe" world if type checking and coercion would to happen here as we discussed, each of those strings elements would be typecast to a stringlist. That actually means the resulting decision value is [["123"], ["abc"], ["true"] ], not ["123, 'abc","true"] as the test is asserting. That is a list of lists, not a 'stringlist" as the decision is typed for. Thus, the result of the decision would be coerced to null.

I would say, either change the list element typerefs to all be "string", or remove the explicit typeRefs from them.

@opatrascoiu
Copy link
Contributor Author

@StrayAlien Well spotted! The editor that I used has some issues. I have fixed the typeRefs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0