8000 Remove unused appveyor config by ibuclaw · Pull Request #567 · dlang-community/dfmt · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove unused appveyor config #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 6, 2022
Merged

Remove unused appveyor config #567

merged 2 commits into from
Oct 6, 2022

Conversation

ibuclaw
Copy link
Contributor
@ibuclaw ibuclaw commented Oct 3, 2022

This is now possible now the site now has a new front for its bucket.

@ibuclaw ibuclaw added the trivial label Oct 3, 2022
@rikkimax
Copy link
Contributor
rikkimax commented Oct 3, 2022

Do we use appveyor anymore?

It's not the in the checks of this PR.

@ibuclaw
Copy link
Contributor Author
ibuclaw commented Oct 3, 2022

No idea, all dead pipelines and scripts should be removed for everyone's sanity. :-)

@WebFreak001
Copy link
Member

I don't think we use appveyor, we only use GitHub Actions now.

Also why does this update the git submodules?

@ibuclaw
Copy link
Contributor Author
ibuclaw commented Oct 6, 2022

I don't think we use appveyor, we only use GitHub Actions now.

OK, will delete.

Also why does this update the git submodules?

Maybe I didn't run submodule update?

@WebFreak001
Copy link
Member

submodules are still modified here, updating the submodules should be a separate PR that also updates the dub.json to make the two use the same version.

@ibuclaw
Copy link
Contributor Author
ibuclaw commented Oct 6, 2022

submodules are still modified here, updating the submodules should be a separate PR that also updates the dub.json to make the two use the same version.

Again, I didn't run submodule update, I haven't updated the submodules locally since 2019. Seems odd to me that GitHub includes that detail in the PR. 🤷

@WebFreak001
Copy link
Member
WebFreak001 commented Oct 6, 2022

now it looks like the appveyor file is back and the submodule changes are still there.

Try undoing your last commit and redo the whole thing and just delete the appveyor file (don't add the submouldes when committing)

@ibuclaw
Copy link
Contributor Author
ibuclaw commented Oct 6, 2022

@WebFreak001 it's been years since I last used a submodule - now I remember why I never used them. :-)

@WebFreak001 WebFreak001 changed the title Update downloads.dlang.org links to use https Remove unused appveyor config Oct 6, 2022
@WebFreak001 WebFreak001 merged commit e251e43 into dlang-community:master Oct 6, 2022
@ibuclaw ibuclaw deleted the httpsdownloads branch October 6, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0