10000 upgrade libdparse by WebFreak001 · Pull Request #965 · dlang-community/D-Scanner · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
8000

upgrade libdparse #965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2025
Merged

upgrade libdparse #965

merged 1 commit into from
Mar 23, 2025

Conversation

WebFreak001
Copy link
Member

adds support for interpolated strings

@rikkimax
Copy link
Contributor
rikkimax commented Mar 1, 2025

I don't understand how this is passing.

    Cleaning artifacts for package dscanner at C:\Users\alpha\AppData\Local\dub\cache\dscanner\0.16.0-beta.4+commit.18.g3a87c65
   Upgrading project in Q:\Misc Software\D-Dev-Tools\D-Scanner\
     Warning Warning: License in sub-package dcd:dsymbol is different than its parent package, this is discouraged.
    Starting Performing "release" build using ldc2 for x86_64.
  Up-to-date emsi_containers 0.9.0: target for configuration [library] is up to date.
    Building libdparse 0.25.0: building configuration [library]
    Building dcd:dsymbol 0.16.0-beta.3: building configuration [library]
  Up-to-date inifiled 1.3.3: target for configuration [library-quiet] is up to date.
  Up-to-date libddoc:common 0.8.0: target for configuration [library] is up to date.
    Building libddoc 0.8.0: building configuration [lib]
    Building dscanner 0.16.0-beta.4+commit.18.g3a87c65: building configuration [application]
   Pre-build Running commands
src\dscanner\analysis\mismatched_args.d(56,52): Error: no property `argNames` for `sym` of type `const(dsymbol.symbol.DSymbol)*`

https://github.com/dlang-community/D-Scanner/blob/master/src/dscanner/analysis/mismatched_args.d#L56

Offending PR: dlang-community/DCD#763

@rikkimax
Copy link
Contributor
rikkimax commented Mar 1, 2025

Oh I see, DCD wasn't updated.

https://github.com/dlang-community/D-Scanner/blob/master/dub.selections.json#L4

@LightBender
Copy link

Are we waiting on anything to merge this?

@rikkimax
Copy link
Contributor
rikkimax commented Mar 6, 2025

Apart from the fact that if we did merge it, people who are not me are going to complain about it being broken?

Clone it, run dub upgrade on it, and try to build it. Just watch.

@pbackus
Copy link
pbackus commented Mar 6, 2025

DCD has already been updated upstream, so we should be good to go here once we upgrade the submodule and dub.json, right?

@thewilsonator
Copy link

What's the status of this? can we merge it. This is now holding up PRs.

@pbackus pbackus mentioned this pull request Mar 22, 2025
Merged
@WebFreak001 WebFreak001 merged commit dc907e4 into dlang-community:master Mar 23, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LightBender LightBender LightBender approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@WebFreak001 @rikkimax @LightBender @pbackus @thewilsonator
0