Replace SkipPackageSuppliers.default_ usage with Nullable #3033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of having a different enum value for stating that the value is not specified and it should be taken from the configuration files, use a Nullable. This has been suggested in dlang#2903 (comment) The main reason for this change is going through the other places where the configuration files were not honored (e.g. dub lint) (which was the intent of the original PR). It would be a shorter change to modify the current code to use the .default_ enum value when it was appropriate but if I have to change the code I might as well go and implement the less error-prone solution with Nullable. Signed-off-by: Andrei Horodniceanu <a.horodniceanu@proton.me>
|
✅ PR OK, no changes in deprecations or warnings Total deprecations: 0 Total warnings: 0 Build statistics: statistics (-before, +after)
-executable size=5105200 bin/dub
+executable size=5101104 bin/dub
rough build time=59sFull build output |
|
The diff looks good, but I can't help but think the real issue here is that argument parsing and configuration file loading are so far appart. If the |
|
Maybe, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having a different enum value for stating that the value is not specified and it should be taken from the configuration files, use a Nullable. This has been suggested in #2903 (comment)
The main reason for this change is going through the other places where the configuration files were not honored (e.g. dub lint) (which was the intent of the original PR). It would be a shorter change to modify the current code to use the .default_ enum value when it was appropriate but if I have to change the code I might as well go and implement the less error-prone solution with Nullable.