8000 fix: Don't add single package files to sourceFiles by Geod24 · Pull Request #3032 · dlang/dub · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: Don't add single package files to sourceFiles #3032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2025
Merged

fix: Don't add single package files to sourceFiles #3032

merged 1 commit into from
May 23, 2025

Conversation

Geod24
Copy link
Member
@Geod24 Geod24 commented May 22, 2025

They get added automatically via the mainSourceFile path, so rely on this. This work around a bug in Windows + git bash where the file gets mentioned twice on the command line.

This should fix #3030 but the underlying bug can still be triggered with a package and mainSourceFile, but fixing that requires a deeper refactoring.

@github-actions GitHub Actions
Copy link
github-actions bot commented May 22, 2025 •
edited
Loading

✅ PR OK, no changes in deprecations or warnings

Total deprecations: 0

Total warnings: 0

Build statistics:

 statistics (-before, +after)
 executable size=5055888 bin/dub
-rough build time=60s
+rough build time=61s
Full build output 
DUB version 1.39.0, built on Mar 20 2025
LDC - the LLVM D compiler (1.40.1):
  based on DMD v2.110.0 and LLVM 19.1.7
  built with LDC - the LLVM D compiler (1.40.1)
  Default target: x86_64-unknown-linux-gnu
  Host CPU: znver3
  http://dlang.org - http://wiki.dlang.org/LDC


  Registered Targets:
    aarch64     - AArch64 (little endian)
    aarch64_32  - AArch64 (little endian ILP32)
    aarch64_be  - AArch64 (big endian)
    amdgcn      - AMD GCN GPUs
    arm         - ARM
    arm64       - ARM64 (little endian)
    arm64_32    - ARM64 (little endian ILP32)
    armeb       - ARM (big endian)
    avr         - Atmel AVR Microcontroller
    bpf         - BPF (host endian)
    bpfeb       - BPF (big endian)
    bpfel       - BPF (little endian)
    hexagon     - Hexagon
    lanai       - Lanai
    loongarch32 - 32-bit LoongArch
    loongarch64 - 64-bit LoongArch
    mips        - MIPS (32-bit big endian)
    mips64      - MIPS (64-bit big endian)
    mips64el    - MIPS (64-bit little endian)
    mipsel      - MIPS (32-bit little endian)
    msp430      - MSP430 [experimental]
    nvptx       - NVIDIA PTX 32-bit
    nvptx64     - NVIDIA PTX 64-bit
    ppc32       - PowerPC 32
    ppc32le     - PowerPC 32 LE
    ppc64       - PowerPC 64
    ppc64le     - PowerPC 64 LE
    r600        - AMD GPUs HD2XXX-HD6XXX
    riscv32     - 32-bit RISC-V
    riscv64     - 64-bit RISC-V
    sparc       - Sparc
    sparcel     - Sparc LE
    sparcv9     - Sparc V9
    spirv       - SPIR-V Logical
    spirv32     - SPIR-V 32-bit
    spirv64     - SPIR-V 64-bit
    systemz     - SystemZ
    thumb       - Thumb
    thumbeb     - Thumb (big endian)
    ve          - VE
    wasm32      - WebAssembly 32-bit
    wasm64      - WebAssembly 64-bit
    x86         - 32-bit X86: Pentium-Pro and above
    x86-64      - 64-bit X86: EM64T and AMD64
    xcore       - XCore
    xtensa      - Xtensa 32
   Upgrading project in /home/runner/work/dub/dub/
    Starting Performing "release" build using /opt/hostedtoolcache/dc/ldc2-1.40.1/x64/ldc2-1.40.1-linux-x86_64/bin/ldc2 for x86_64.
    Building dub 1.40.0+commit.19.g2e44555b: building configuration [application]
     Linking dub
STAT:statistics (-before, +after)
STAT:executable size=5055888 bin/dub
STAT:rough build time=61s

@kinke
Copy link
Contributor
kinke commented May 22, 2025

I think stable is already affected (at least the installer branch CI was), so please re-target.

@Geod24 Geod24 changed the base branch from master to stable May 22, 2025 21:05
@Geod24
fix: Don't add single package files to sourceFiles
b45ed49 
They get added automatically via the mainSourceFile path, so rely on this.
This work around a bug in Windows + git bash where the file gets mentioned
twice on the command line.
@Geod24 Geod24 force-pushed the mlang/FixSingleFile branch from 6374a53 to b45ed49 Compare May 22, 2025 21:06
@Geod24
Copy link
Member Author
Geod24 commented May 22, 2025

Targeting stable now

@Geod24 Geod24 merged commit ea58df6 into dlang:stable May 23, 2025
32 checks passed
@Geod24 Geod24 deleted the mlang/FixSingleFile branch May 23, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kinke kinke kinke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows: Single source file with --single mentioned twice in compiler command-line (with different slashes)
2 participants
@Geod24 @kinke
0