8000 Add restic check handling by skimpax · Pull Request #90 · djmaze/resticker · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add restic check handling #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 8, 2021
Merged

Add restic check handling #90

merged 4 commits into from
Jun 8, 2021

Conversation

skimpax
Copy link
Contributor
@skimpax skimpax commented May 1, 2021

Add support of 'restic check' command in resticker, update examples and Readme accordingly.

Copy link
Owner
@djmaze djmaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works for me. Thanks, good work and a very nice addition!

@@ -29,7 +29,7 @@ start=`date +%s`
echo Starting Backup at $(date +"%Y-%m-%d %H:%M:%S")

set +e
restic backup ${RESTIC_BACKUP_ARGS:-} ${tag_options} ${RESTIC_BACKUP_SOURCES}
restic --repo="${RESTIC_REPOSITORY}" backup ${RESTIC_BACKUP_ARGS:-} ${tag_options} ${RESTIC_BACKUP_SOURCES}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just to make it more obvious?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.
Motivation was that check command based on exiting format was raising a restic error.
It seems 'restic check' does not parse parameters the same way as 'restic backup`.
To cope with this, I changed the syntax to be closer to restic documentation examples... and its more obvious, indeed.

@djmaze
Copy link
Owner
djmaze commented Jun 8, 2021

Okay, sorry for the late response. Merging.

@djmaze djmaze merged commit c706317 into djmaze:master Jun 8, 2021
@djmaze djmaze added this to the 1.4.1 milestone Jun 8, 2021
jeankhawand pushed a commit to jeankhawand/resticker that referenced this pull request Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0