Fix: keep the existing dependent_jobs value on updating an existing job #1761
+58
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Instructs the store to include existing dependent_jobs on job update.
Currently the dependent_jobs slice gets reset to nil on updating an existing job, this breaks the job chaining feature.
EDIT: i forgot to mention with the original post, This is only a problem when using the API to update a job, when using the web ui the dependent_jobs field is pulled from the existing job payload and sent along with the update request.
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply