8000 Feature(ci): Autogen API client on spec change by xBlaz3kx · Pull Request #1703 · distribworks/dkron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Feature(ci): Autogen API client on spec change #1703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 8, 2025
Merged

Feature(ci): Autogen API client on spec change #1703

merged 4 commits into from
Apr 8, 2025

Conversation

xBlaz3kx
Copy link
Contributor

Proposed changes

  • Added workflow for validating OpenAPI spec
  • Added autogeneration of the OpenAPI client when the spec changes

(Solves ##1701)

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

@xBlaz3kx
Copy link
Contributor Author

Note: New workflow wasnt run because OpenAPI spec was not changed. If you want to try out the workflow, I suggest checking out my branch and running the action using nektos/act tool or you can take this PR as a reference.

Sidenote 2: OpenAPI validation is failing, not sure why.

@xBlaz3kx xBlaz3kx closed this Mar 18, 2025
@xBlaz3kx xBlaz3kx deleted the feat/openapi-client-gen branch March 18, 2025 23:00
@xBlaz3kx xBlaz3kx restored the feat/openapi-client-gen branch March 18, 2025 23:00
@xBlaz3kx xBlaz3kx reopened this Mar 18, 2025
@xBlaz3kx xBlaz3kx requested a review from yvanoers March 20, 2025 22:27
yvanoers
yvanoers requested changes Mar 25, 2025
View reviewed changes
Copy link
Collaborator
@yvanoers yvanoers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! One more thing, though.

@xBlaz3kx xBlaz3kx requested a review from yvanoers March 25, 2025 21:05
@xBlaz3kx xBlaz3kx changed the title feat: Autogen API client on spec change Feature: Autogen API client on spec change Mar 27, 2025
@xBlaz3kx xBlaz3kx changed the title Feature: Autogen API client on spec change Feature(ci): Autogen API client on spec change Mar 27, 2025
yvanoers
yvanoers previously approved these changes Mar 31, 2025
View reviewed changes
@yvanoers
Copy link
Collaborator

@vcastellm This LGTM, ready to merge at your discretion.

vcastellm
vcastellm approved these changes Apr 8, 2025
View reviewed changes
Copy link
Member
@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vcastellm vcastellm merged commit 5007305 into distribworks:main Apr 8, 2025
1 of 3 checks passed
@xBlaz3kx xBlaz3kx deleted the feat/openapi-client-gen branch April 8, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcastellm vcastellm vcastellm approved these changes

@yvanoers yvanoers yvanoers left review comments

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xBlaz3kx @yvanoers @vcastellm
0