8000 Update message deleting by key2peace · Pull Request #736 · discord-php/DiscordPHP · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update message deleting #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Feb 24, 2022
Merged

Update message deleting #736

merged 10 commits into from
Feb 24, 2022

Conversation

key2peace
Copy link
Collaborator
@key2peace key2peace commented Feb 23, 2022 •
edited by SQKo
Loading
  • Add reason headers to $message->delete
  • Update $channel->deleteMessages by looping through messages and check if they aren't older then 14 days, if they are, remove them from the bulk_delete batch and delete them individually.

@key2peace
Update message deleting
646c527 
- Add reason headers to $message->delete
- Update $channel->deleteMessages by looping through messages and check if they aren't older then 14 days, if they are, remove them from the bulk_delete batch and remove them individually.
@key2peace key2peace requested a review from SQKo February 23, 2022 19:20
@key2peace
Copy link
Collaborator Author
key2peace commented Feb 23, 2022 •
edited by SQKo
Loading

addresses #653 and #735

SQKo
SQKo requested changes Feb 24, 2022
View reviewed changes
SQKo
SQKo reviewed Feb 24, 2022
View reviewed changes
Copy link
Member
@SQKo SQKo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ugly workaround

SQKo
SQKo previously approved these changes Feb 24, 2022
View reviewed changes
@SQKo SQKo merged commit 397c522 into discord-php:master Feb 24, 2022
@key2peace key2peace deleted the update/bulkDelete branch February 28, 2022 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SQKo SQKo SQKo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@key2peace @SQKo
0