8000 Bump version, deprecate invite stage instance, thread updateable by SQKo · Pull Request #728 · discord-php/DiscordPHP · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Bump version, deprecate invite stage instance, thread updateable #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 16, 2022
Merged

Bump version, deprecate invite stage instance, thread updateable #728

merged 5 commits into from
Feb 16, 2022

Conversation

SQKo
Copy link
Member
@SQKo SQKo commented Feb 16, 2022 •
edited
Loading
  • Bump version to 7.0.2
  • Deprecate stage instance attribute in invite Deprecate Invite Stage Instance discord/discord-api-docs#4479
  • Fix phpdoc Member::moveMember() parameter $channel nullable
  • Add updateable attributes for Thread, the following functions are separate to be used by Bots without MANAGE_THREAD permissions:
    • Add Thread::rename()
    • Add Thread::setAutoArchiveDuration()
    • Add audit log $reason parameters for Thread::archive() and Thread::unarchive()

Tested.

EDIT: also added Attachment stuff to MessageBuilder, this seems required to keep attachment in editing messages or not to append them when creating messages. (The behavior is required in Discord API v10)

@SQKo
Copy link
Member Author
SQKo commented Feb 16, 2022 •
edited
Loading

Also added Op::CLOSE_NORMAL code 1000 with $discord->close(), but since it's technically impossible to send the code with default close loop set to true, you have to set close loop to false and then close the loop after the opcode has been send.

This is how to exit bot gracefully and make it offline:

$discord->close(false);
$loop = $discord->getLoop();
$loop->futureTick([$loop, 'stop']);

@SQKo SQKo merged commit 9248705 into discord-php:master Feb 16, 2022
@SQKo SQKo deleted the patch-55 branch February 16, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@key2peace key2peace key2peace approved these changes

@valzargaming valzargaming Awaiting requested review from valzargaming

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SQKo @key2peace
0