Added a few @throws in the doc comments. #40
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -136,6 +137,7 @@ public function api($options, callable $callback) | |||
| * | |||
| * @param \Illuminate\Http\Request $request | |||
| * @return \Illuminate\Http\Response|\Dingo\Api\Http\Response | |||
| * @throws \HttpExceptionInterface | |||
There was a problem hiding this comment.
Missing the full Symfony namespace reference here.
|
Any chance you could squash all these commits? Cheers. |
|
Opps sorry that other pull request is for something totally different but it wouldn't let me separate it, should of branched. Sorry. |
Currently the Fractal Illuminate adapter fails to take the query string parameters required. The idea I am using is that rather then creating a new instance of the paginator just using the one that is already provided. The wrapper just makes it bind to the contract of PaginatorInterface. This currently breaks tests as I have been going round and round trying to fix it, sorry for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.