L5.4: Rename the router's middleware method to aliasMiddleware #1316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasmichot
reviewed
Jan 25, 2017
| * with Laravel < 5.4 check if aliasMiddleware exists since this | ||
| * method has been renamed. | ||
| * | ||
| * @param $name |
There was a problem hiding this comment.
@param string $name
@param string $class
@return \Illuminate\Routing\Router
There was a problem hiding this comment.
thx, I added the typehints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Laravel 5.4 the routers
middlewareMethod was renamed toaliasMiddlewaresee: laravel/framework@06303d9In addition to this I updated the composer version constraints to allow illuminate 5.4 components to be installed which should make this package Laravel 5.4 compatible. I could not find any other issues in my testing.
Also this PR: dingo/blueprint#54