FormRequest->withValidator is not working as validateResolved is not getting called. #1654
Conversation
Allow https route declaration with 'https' array key and value.
```
$router->group(['https' => true], function (Router $router) {
});
```
|
@specialtactics, Can you please look into it ? |
Allow https route declaration with 'https' array key and value
|
Hey @sudkumar sorry mate, I've been very busy, I will look at this shortly! |
|
Thank you. @specialtactics I used the PR's commit till now. I did not find any test case that I should update. So please let me know where/how I should write one if needed. |
Apply fixes from StyleCI
FormRequest->withValidator is not working as validateResolved is not getting called.
|
@sudkumar I don't know why, but github says there's conflicts, so pull master and update please. I've had a look, and everything looks fine. The laravel service provider actually doesn't even have this, which is odd - I will go and look into that separately now as well. |
|
Alright. I'll update. |
|
Hi @specialtactics . I swear I did not close this. It says the commits have been merged!! I did not get it :/ |
|
Hey @sudkumar I think you've done something funny while pulling in master 😛 Maybe just sync your repo and make a fresh PR ? Alternatively I could just make the change for you. |
|
Actually @sudkumar it seems like it was in fact already merged. Very weird github says closed instead of merged! |
|
I only took pull from dingo/api#master and pushed it back. No idea. =D But it is merged and that's what we need. Thank you. :) |
|
I added the same to the LaravelServiceProvider now: Thanks for your contribution ! |
Fixes #1653