Minor updates to docs #837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dimitri If you could review the small docs changes here, we can pull them for 0.17 perhaps |
dimitri
requested changes
Jul 10, 2024
There was a problem hiding this comment.
Thanks for the docs review! Many good changes, a lot of stylistics changes that I don't know if they are improvements, because I'm not a native English speaker, but I would default to accept them.
That said, there are a small number of misinformed/misleading changes in your PR that I think should be fixed before merge. Please consider fixing them as per the detailed review below.
9288110 to
e8e2df5
Compare
|
Commented and sent the new changes commit |
dimitri
approved these changes
Jul 15, 2024
rimbi
pushed a commit
to rimbi/pgcopydb
that referenced
this pull request
Jul 22, 2024
Sign up for
668D
free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some edits regarding fixing typos and expressions for better readability and grammar. Note that Reference Manual section is omitted and shall not be included.