Vaccum workers must be stopped after index workers #815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vacuum workers are signaled to STOP as soon as the table copy workers are done. This is incorrect, as the index process can still work on indexes even after the termination of copy workers. Vacuum workers should only be signaled to stop once all indexes are processed. Solution: From the index supervisor, send the STOP signal to the vacuum workers after all index workers have exited. This preserves the order of worker termination. Fixes dimitri#812 Signed-off-by: Arunprasad Rajkumar <ar.arunprasad@gmail.com>
dimitri
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vacuum workers are signaled to STOP as soon as the table copy workers are done. This is incorrect, as the index process can still work on indexes even after the termination of copy workers. Vacuum workers should only be signaled to stop once all indexes are processed.
Solution: From the index supervisor, send the STOP signal to the vacuum workers after all index workers have exited. This preserves the order of worker termination.
Fixes #812