Problem: Array out of bounds access during transform #809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic which removes redundant SET for columns who's value is same as in WHERE clause accesses oldValue using newValue index. Both can have varying size items causing out of bound access. We use the correct index to access the old column name, but incorrect index has been used to access the old column value. Solution: Use old column index to access it's value Signed-off-by: Arunprasad Rajkumar <ar.arunprasad@gmail.com>
b075eb5 to
6bd34a9
Compare
dimitri
approved these changes
Jun 7, 2024
|
Thanks @arajkumar ; well spotted! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic which removes redundant SET for columns who's value is same as in WHERE clause accesses oldValue using newValue index. Both can have varying size items causing out of bound access.
We use the correct index to access the old column name, but incorrect index has been used to access the old column value.
Original PR which avoids redundant SET if value is same as in WHERE: #333
Solution: Use old column index to access it's value