8000 Fix issues in the docs. by rimbi · Pull Request #801 · dimitri/pgcopydb · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix issues in the docs. #801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 4, 2024
Merged

Fix issues in the docs. #801

merged 4 commits into from
Jun 4, 2024

Conversation

rimbi
Copy link
Contributor
@rimbi rimbi commented Jun 4, 2024

Fix issues in the docs:

  • Updates the docs and help message with regards to sentinel table as it was moved from source databse to sqlite.
  • Fixes minor grammatical issues in the docs.

@rimbi rimbi requested review from dimitri and hanefi June 4, 2024 11:00
dimitri
dimitri requested changes Jun 4, 2024
View reviewed changes
Copy link
Owner
@dimitri dimitri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

There is only one catch with the pgcopydb sentinel create|drop CLIs that I believe do not exist anymore, right?

README.md Outdated
Comment on lines 116 to 117
create Create the sentinel table
drop Drop the sentinel table
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have these two commands anymore, I believe this PR should also remove the entries from this list.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, fixed. 👍

@dimitri dimitri merged commit 493025b into dimitri:main Jun 4, 2024
19 checks passed
@dimitri dimitri added the documentation Improvements or additions to documentation label Jun 4, 2024
@dimitri dimitri added this to the v0.17 milestone Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimitri dimitri dimitri approved these changes

@hanefi hanefi Awaiting requested review from hanefi

Assignees

@rimbi rimbi

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
v0.17
Development

Successfully merging this pull request may close these issues.
2 participants
@rimbi @dimitri
0