Add more logic around droplet deletes #36

bryanl · 2016-04-04T15:39:20Z

When deleting droplets, cycle through the following logic:

check for ambiguous names. e.g. multiple droplets named ubuntu
build a list of droplets to delete and execute them all at once
don't allow deleting the same droplet twice (by name or id)

Fixes #18

aybabtme · 2016-04-06T14:41:22Z

commands/droplets.go

+	// if list has strings in it, fetch the list
+	list, err := ds.List()
+	if err != nil {
+		return errors.New("unable to create list of droplets")


fmt.Errorf to get the error, otherwise it's lost

aybabtme · 2016-04-06T14:47:51Z

some comments but otherwise 🚢

When deleting droplets, cycle through the following logic: * check for ambiguous names. e.g. multiple droplets named ubuntu * build a list of droplets to delete and execute them all at once * don't allow deleting the same droplet twice (by name or id) Fixes #18

Update commands to use args instead of flags

aybabtme reviewed Apr 6, 2016
View reviewed changes

bryanl force-pushed the droplet-delete-ambiguous branch from 833d00c to 648be63 Compare April 6, 2016 15:38

bryanl merged commit 8ed0083 into master Apr 6, 2016

bryanl deleted the droplet-delete-ambiguous branch April 6, 2016 15:40

andrewsomething pushed a commit to andrewsomething/doctl that referenced this pull request Jun 8, 2016

Merge pull request digitalocean#36 from bryanl/natural-droplet

74d45ff

Update commands to use args instead of flags

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add more logic around droplet deletes #36

Add more logic around droplet deletes #36

Add more logic around droplet deletes #36

Add more logic around droplet deletes #36

Conversation

Choose a reason for hiding this comment