8000 Always easier to see--when it's dark · Pull Request #824 · diasurgical/devilution · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Always easier to see--when it's dark #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from Apr 2, 2019
Merged

Always easier to see--when it's dark #824

merged 2 commits into from Apr 2, 2019

Conversation

ghost
Copy link
@ghost ghost commented Apr 1, 2019

Cleans up the following

SetLightFX - not the same function on the PSX, renamed to RotateRadius
DoLighting
DoVision
MakeLightTable

All bin exact except MakeLightTable, which has one minor swap with EBP location during a conditional. The following line is the diff:

Capture

@ghost ghost added the Binary exact label Apr 1, 2019
@AJenbo AJenbo mentioned this pull request Apr 1, 2019
Closed
24 tasks
@ChaosMarc
Copy link
Contributor

image

66.6% of all functions are binary exact. This calls for release 0.6.6.6 😈

mewmew
mewmew reviewed Apr 1, 2019
View reviewed changes
Copy link
Contributor
@mewmew mewmew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with minor comment. Can we add the enums for dFlags?

e.g.

- 			dFlags[nXPos][nYPos] |= 0x80; 
+ 			dFlags[nXPos][nYPos] |= DFLAG_EXPLORED; 
typedef enum dflag {
	DFLAG_MISSILE     = 0x01,
	DFLAG_VISIBLE     = 0x02,
	DFLAG_DEAD_PLAYER = 0x04,
	DFLAG_POPULATED   = 0x08,
	DFLAG_MONSTER     = 0x10,
	DFLAG_PLAYER      = 0x20,
	DFLAG_LIT         = 0x40,
	DFLAG_EXPLORED    = 0x80,
} dflag;

@mewmew
Copy link
Contributor
mewmew commented Apr 1, 2019

P.S. I was listening to https://www.youtube.com/watch?v=p32b5nNq1zw while doing the code review, definitely put me in the mood :)

@ghost
Copy link
Author
ghost commented Apr 2, 2019

@ChaosMarc Does it? or does it.......

@mewmew Don't be afraid of the dark now. Embrace it! werehererere

@mewmew mewmew merged commit 11a2e48 into diasurgical:master Apr 2, 2019
@ghost ghost deleted the LightsOut branch April 2, 2019 12:00
@AJenbo
Copy link
Member
AJenbo commented Apr 2, 2019

Now I defiantly have to go on a coding vacation :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Binary exact
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ChaosMarc @mewmew @AJenbo @qndel @galaxyhaxz
0