8000 Clean up AddBarrel by AJenbo · Pull Request #535 · diasurgical/devilution · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Clean up AddBarrel #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 31, 2018
Merged

Clean up AddBarrel #535

merged 1 commit into from
Dec 31, 2018

Conversation

AJenbo
Copy link
Member
@AJenbo AJenbo commented Dec 31, 2018

The difference is just a couple of instructions appearing in a different order:
billede

Most importantly though this removes one usage of OFSUB and so brings us closer to being able to compile objects.cpp as C.

@AJenbo AJenbo mentioned this pull request Dec 31, 2018
Closed
38 tasks
mewmew
mewmew approved these changes Dec 31, 2018
View reviewed changes
Copy link
Contributor
@mewmew mewmew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mewmew mewmew merged commit 2c8cec0 into diasurgical:nightly Dec 31, 2018
@AJenbo AJenbo mentioned this pull request Dec 31, 2018
Closed
@mewmew
Copy link
Contributor
mewmew commented Dec 31, 2018

I added this PR to #269 so we can track the minimal difference.

@AJenbo AJenbo deleted the AddBarrel branch December 31, 2018 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mewmew mewmew mewmew approved these changes

Assignees
No one assigned
Labels
Minimal differences
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AJenbo @mewmew
0