Fix a bug in palette_update
#8031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR diasurgical#8027 exposed a bug in `palette_update`. The `first` argument in SDL palette functions always refers to the first target index (the first source index is always 0).
StephenCWills
approved these changes
Jun 7, 2025
There was a problem hiding this comment.
My kneejerk reaction was that this feels wrong, because we pass first in as the very next argument. If anyone else feels skeptical, rest assured that I verified it independently by checking SDL documentation and SDL1 source code. That argument only provides the offset into the SDL_Palette data (and also the surface palette in the case of SDL1). It does not assume the offset should also apply to the color buffer that we pass in.
|
Yes, it's a rather weird API because the input and output arguments are intermixed, the order is:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #8027 exposed a bug in
palette_update.The
firstargument in SDL palette functions always refers to the first target index (the first source index is always 0).Fixes poison water following #8027.