8000 Modernize for module support and proper CLI library referencing by jbuchbinder · Pull Request #1 · dhogborg/go-pocsag · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Modernize for module support and proper CLI library referencing #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
8000
from
Open

Modernize for module support and proper CLI library referencing #1

wants to merge 1 commit into from

Conversation

jbuchbinder
Copy link

Modernize library to make use of go modules and use the new location of the referenced CLI library.

@dhogborg
Copy link
Owner

Thank you for you contribution!

What is the rationale behind having multiple go.mod files? This app does not publish multiple packages (in fact, non at all, since they reside in internal), and besides what would be better served by a go.work file.

I'm all for adding a go.mod file, but it should be a single one in the project root. If there is a demand for accessing the implementation as modules then renaming internal to pkg would be preferable to multiple go.mod files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbuchbinder @dhogborg
0