-
Notifications
You must be signed in to change notification settings - Fork 130
new feature: name a cell range and few minor fixes #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
494e313
fix: localSheetId was always set to 0 instead of assigning the right …
dorssar 4cb3dda
new feature: name cell ranges
dorssar 999968d
added forgotten function for named ranges functionality
dorssar e379705
defined a specific name range that LibreOffice needs to recognize aut…
dorssar 99df6bb
aesthetics: added some comments
dorssar 4a26534
fix: in case the sheetname contains a space or any other odd characte…
dorssar 4fc9dd2
improved javadoc comments for named range functions
dorssar d4e3d27
corrected invalid javadoc comment
dorssar fe6beef
fix: when sheetname contains space or some other non-alphabetical cha…
dorssar b39611b
Merge remote-tracking branch 'upstream/master'
dorssar 590303b
Update README.md
dorssar 8a78904
Merge remote-tracking branch 'upstream/master'
dorssar e9aacb8
Merge branch 'master' of https://github.com/dorssar/fastexcel
dorssar 51d776a
added a new test validating named range functionality with Apache POI
dorssar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If defineName and namesRanges are empty then will never be closed.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you overlooked (it's being closed on line 254 either way).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So if both
defineName
andnamedRanges
are not empty, then it will be closed twice?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will be opened and then closed only once, but there are conditional <definedName> tags inside of this <definedNames> tag.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If they are empty - we'll have <definedNames></definedNames>, otherwise if any of them are non-empty we will have
There was a problem hiding this comment.
Choose a reason for hidin EDBE g this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh. I see it now. I misstook line 221 as
</definedNames>
. Nevertheless I would be good to cover this part of code in a test.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, will try to do that. Where should I put this test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can put it in a new class in
src/test/java
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I put it into PoiCompatibilityTest.java ? I guess all of the existing similar tests are there ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
Done!