fix: I needed to run ollama serve first, fix: put route in for vite ping #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgurns
reviewed
May 3, 2025
There was a problem hiding this comment.
Appreciate the PR @bettlebrox!!
Just a question on the readme
| @@ -19,13 +19,14 @@ cp .env.sample .env | |||
| 2. Download the local LLM and serve it via Ollama: | |||
|
|
|||
| ```bash | |||
| # start ollama so you can pull the model | |||
| # Or run the Ollama desktop app to serve automatically | |||
| ollama serve | |||
There was a problem hiding this comment.
Wouldn't you have to pull the model first before serving it?
There was a problem hiding this comment.
I think serve is just to start ollama. I don't have the desktop app so if I don't start ollama I can't pull.
dgurns
reviewed
May 3, 2025
| @@ -6,4 +6,5 @@ export default [ | |||
| route("/second-opinion", "routes/second-opinion.tsx"), | |||
| route("/clear-details", "routes/clear-details.tsx"), | |||
| route("/delete-detail", "routes/delete-detail.tsx"), | |||
| route("/__vite_ping", "routes/noop.tsx") | |||
There was a problem hiding this comment.
What's the purpose of this route? Would have assumed any kind of internal Vite healthcheck is handled by the Vite dev server itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.