8000 fix: make `vec::InitError` public again by ielashi · Pull Request #100 · dfinity/stable-structures · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: make vec::InitError public again #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

8000 Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

ielashi
Copy link
Contributor
@ielashi ielashi commented Jul 6, 2023

The refactoring of vec accidentally made vec::InitError private, which broke clients that upgraded to the latest stable structures release. See issue #98.

This commit makes vec::InitError public, and adds a test to ensure it always remains public.

@ielashi ielashi requested review from a team and roman-kashitsyn as code owners July 6, 2023 11:10
@ielashi ielashi changed the title fix: expose vec::InitError fix: make vec::InitError public again Jul 6, 2023 8000
Copy link
Contributor
@roman-kashitsyn roman-kashitsyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@roman-kashitsyn roman-kashitsyn merged commit fd8af99 into main Jul 6, 2023
@roman-kashitsyn roman-kashitsyn deleted the ielashi/vec_init_error branch July 6, 2023 11:41
ielashi added a commit that referenced this pull request Jul 6, 2023
Bumping the version is needed to roll out the fix in #100.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0