8000 feat(portfolio): integrate privacy display in rows cards by yhabib · Pull Request #6862 · dfinity/nns-dapp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(portfolio): integrate privacy display in rows cards #6862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: nns1-3721/hide-balances-in-cards
Choose a base branch
from
Open

feat(portfolio): integrate privacy display in rows cards #6862

wants to merge 1 commit into from
+78 −14

Conversation

yhabib
Copy link
Contributor
@yhabib yhabib commented May 21, 2025

Motivation

We want to introduce a toggle that allows users to hide or show their balances on the main pages. This PR adds the PrivacyAwareAmount to the card rows displayed on the portfolio page.

Screenshot 2025-05-21 at 22 23 07
Screen.Recording.2025-05-21.at.22.24.42.mov

NNS1-3721

Changes

  • Wrap amounts on PrivacyAwareAmount.

Tests

  • Add a unit test to cover the hide flow.

Todos

  • Add entry to changelog (if necessary).
    Not necessary.

@yhabib yhabib marked this pull request as ready for review May 21, 2025 20:26
@yhabib yhabib requested a review from a team as a code owner May 21, 2025 20:26
@yhabib yhabib force-pushed the nns1-3721/hide-balances-in-cards branch from 6cce1eb to 4341a1c Compare May 22, 2025 10:15
mstrasinskis
mstrasinskis approved these changes May 22, 2025
View reviewed changes
Copy link
Contributor
@mstrasinskis mstrasinskis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yhabib yhabib force-pushed 8898 the nns1-3721/hide-balances-in-cards branch from 4341a1c to f735a9d Compare May 22, 2025 11:28
@yhabib yhabib force-pushed the nns1-3721/hide-table-rows branch from b5e28f5 to 0d02353 Compare May 22, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstrasinskis mstrasinskis mstrasinskis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yhabib @mstrasinskis
0