fix(scroll): upgrade gix to restore infinite scrolling #6857
+43
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9432167 to
b341c43
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the Gix component library and refactors all InfiniteScroll consumers to match the new Svelte 5 interface.
- Upgrade Gix dependency and adjust
InfiniteScrollAPI usage - Refactor all
loadNext*functions to returnPromise<void> - Replace legacy
on:nnsIntersectwith the newonIntersectprop binding
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/lib/pages/SnsProposals.svelte | Updated loadNextPage signature and prop binding |
| frontend/src/lib/pages/NnsWallet.svelte | Switched to new loadNextTransactions prop shorthand |
| frontend/src/lib/pages/NnsProposals.svelte | Renamed findNextProposals and updated handler binding |
| frontend/src/lib/components/sns-proposals/SnsProposalsList.svelte | Refactored InfiniteScroll usage and event handler |
| frontend/src/lib/components/proposals/UniverseWithActionableProposals.svelte | Added no-op onIntersect stub to disabled scroll |
| frontend/src/lib/components/proposals/NnsProposalsList.svelte | Refactored InfiniteScroll usage and handler binding |
| frontend/src/lib/components/neuron-detail/Ballots/Ballots.svelte | Made showMore async and switched to onIntersect |
| frontend/src/lib/components/accounts/UiTransactionsList.svelte | Introduced loadNextTransactions prop and updated InfiniteScroll |
| frontend/src/lib/components/accounts/IcrcWalletTransactionsList.svelte | Switched to new shorthand loadNextTransactions prop |
Files not reviewed (1)
- frontend/package-lock.json: Language not supported
Comments suppressed due to low confidence (1)
frontend/src/lib/components/neuron-detail/Ballots/Ballots.svelte:29
- [nitpick] The
showMorefunction name is inconsistent with otherloadNext*patterns. Consider renaming it (e.g.,loadMoreBallots) to keep naming consistent across infinite-scroll handlers.
const showMore = async () => {
frontend/src/lib/components/sns-proposals/SnsProposalsList.svelte
Outdated
Show resolved
Hide resolved
frontend/src/lib/components/proposals/UniverseWithActionableProposals.svelte
Show resolved
Hide resolved
849c531 to
e5bd510
Compare
435a6fe to
2c73610
Compare
2c73610 to
9c21f66
Compare
Any commits made after this event will not be merged.
Any commits made after this event will not be merged.
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 22, 2025
# Motivation We want to upgrade the version of Gix in the nns-dapp to address an issue with Infinite Scrolling. The latest version of GIX introduced a breaking change to `InfiniteScroll` when migrating it to Svelte 5. This PR builds on top of #6859 and refactors how these components consume the `InfiniteScroll`. Note: This upgrade fixes the issue of all lists not fetching next pages. Before: Not all votes are being loaded: https://github.com/user-attachments/assets/4b71cf51-d18f-427e-a9f7-97f67adc4fa4 Not all proposals for a project are being loaded by scrolling: https://github.com/user-attachments/assets/b81273ff-3d87-4b7d-a881-4fe0cb39c2b9 After: All votes are being loaded: https://github.com/user-attachments/assets/bcf125c9-f567-48d7-9d30-b3b4c29b0291 All proposals for a project are being loaded by scrolling: https://github.com/user-attachments/assets/6d9ba8f7-db19-414a-bcb8-24e0b7048159 # Changes - Upgrade the GIX component library to the latest version. - Update the consumers of `InfiniteScroll` to the new interface 73D5 . # Tests - Pipeline should work as before. - Manually tested in [devenv](https://qsgjb-riaaa-aaaaa-aaaga-cai.yhabib-ingress.devenv.dfinity.network/portfolio/). # Todos - [x] Add entry to changelog (if necessary).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to upgrade the version of Gix in the nns-dapp to address an issue with Infinite Scrolling. The latest version of GIX introduced a breaking change to
InfiniteScrollwhen migrating it to Svelte 5.This PR builds on top of #6859 and refactors how these components consume the
InfiniteScroll.Note: This upgrade fixes the issue of all lists not fetching next pages.
Before:
Not all votes are being loaded:
Screen.Recording.2025-05-21.at.15.21.42.mov
Not all proposals for a project are being loaded by scrolling:
Screen.Recording.2025-05-21.at.15.25.33.mov
After:
All votes are being loaded:
Screen.Recording.2025-05-21.at.15.28.04.mov
All proposals for a project are being loaded by scrolling:
Screen.Recording.2025-05-21.at.15.29.26.mov
Changes
InfiniteScrollto the new interface.Tests
Todos