8000 chore(deps): upgrade rust to 1.87 and fix warnings by yhabib · Pull Request #6842 · dfinity/nns-dapp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore(deps): upgrade rust to 1.87 and fix warnings #6842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2025

Conversation

yhabib
Copy link
Contributor
@yhabib yhabib commented May 16, 2025

Motivation

#6840 is attempting to upgrade Rust to the latest version but is failing. The compiler appears to have become smarter and can now detect that the #[must_use] attribute has no effect when applied to methods of a trait implementation.

Changes

  • Upgrade Rust to 1.87
  • Remove #[must_use] from trait implementation.

Tests

  • Pipeline should pass as before

Todos

  • Add entry to changelog (if necessary).
    Not necessary.

@yhabib yhabib requested a review from jasonz-dfinity May 16, 2025 05:41
@yhabib yhabib marked this pull request as ready for review May 16, 2025 05:46
@yhabib yhabib requested a review from a team as a code owner May 16, 2025 05:46
Copy link
Contributor
@mstrasinskis mstrasinskis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@yhabib yhabib added this pull request to the merge queue May 16, 2025
Merged via the queue into main with commit d705306 May 16, 2025
36 checks passed
@yhabib yhabib deleted the yhabib/chore/upgrade-rust branch May 16, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0