8000 bot: Update proposals candid bindings by pr-automation-bot-public[bot] · Pull Request #6848 · dfinity/nns-dapp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

bot: Update proposals candid bindings #6848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8000
Jump to bottom
Merged
merged 1 commit into from
May 19, 2025
Merged

bot: Update proposals candid bindings #6848

merged 1 commit into from
May 19, 2025
+44 −7

Conversation

pr-automation-bot-public[bot]
Copy link
Contributor
@pr-automation-bot-public pr-automation-bot-public bot commented May 19, 2025 •
edited by mstrasinskis
Loading

Motivation

We would like to render all the latest proposal types.
Even with no changes, just updating the reference is good practice.

Changes

  • Update the version of IC_COMMIT_FOR_PROPOSALS specified in config.json.
  • Updated the proposals candid files to the versions in that commit.
  • Updated the Rust code derived from .did files in the proposals payload rendering crate.

Tests

  • Please check the API updates for any breaking changes that affect our code.
  • Please check for new proposal types and add tests for them.

Breaking changes are:

  • New mandatory fields
    • Removing mandatory fields
    • Renaming fields
    • Changing the type of a field
    • Adding new variants

@pr-automation-bot-public pr-automation-bot-public bot requested a review from a team as a code owner May 19, 2025 03:48
@mstrasinskis mstrasinskis self-requested a review May 19, 2025 09:06
@mstrasinskis mstrasinskis added this pull request to the merge queue May 19, 2025
Merged via the queue into main with commit b9119bb May 19, 2025
36 checks passed
@mstrasinskis mstrasinskis deleted the bot-proposals-update-1747626484 branch May 19, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstrasinskis mstrasinskis mstrasinskis approved these changes

@yhabib yhabib Awaiting requested review from yhabib

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mstrasinskis @gix-bot
0