Sns topics cleanup #6844
Merged
Sns topics cleanup #6844
+9
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR cleans up leftover TODOs and updates the vote delegation state handling in neurons-related components and tests.
- Made voteDelegationState non-optional in the TableNeuron type.
- Updated tests to include the Vote Delegation column and adjusted corresponding grid layouts.
- Removed TODO comments related to stopPropagation and icon color.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/tests/mocks/neurons.mock.ts | Added voteDelegationState property with a default value for tests. |
| frontend/src/tests/lib/components/neurons/NeuronsTable/NeuronsTable.svelte.spec.ts | Updated test expectations to include the Vote Delegation column. |
| frontend/src/lib/types/neurons-table.ts | Changed voteDelegationState from optional to required. |
| frontend/src/lib/modals/sns/neurons/FollowSnsNeuronsByTopicItem.svelte | Removed deprecated TODO comment regarding stopPropagation. |
| frontend/src/lib/modals/sns/neurons/FollowSnsNeuronsByTopicFollowee.svelte | Removed deprecated TODO comment regarding icon color. |
Comments suppressed due to low confidence (1)
frontend/src/tests/lib/components/neurons/NeuronsTable/NeuronsTable.svelte.spec.ts:174
- [nitpick] Double-check that the updated grid template areas fully accommodate the new Vote Delegation column in all responsive layouts.
"cell-9 cell-9"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Vote delegation by topics is now live, but there are still some TODOs left in the code. This PR cleans up those remaining items.
Changes
voteDelegationStatenon-optional.stopPropagationproperty to the checkbox, as it's not needed.Tests
Todos
Not necessary.