8000 refactor(api): migrate getLedgerId to next-gen index canister by yhabib · Pull Request #6830 · dfinity/nns-dapp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor(api): migrate getLedgerId to next-gen index canister #6830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8000
Jump to bottom
Merged
merged 3 commits into from
May 15, 2025
Merged

refactor(api): migrate getLedgerId to next-gen index canister #6830

merged 3 commits into from
May 15, 2025

Conversation

yhabib
Copy link
Contributor
@yhabib yhabib commented May 13, 2025 •
edited
Loading

Motivation

The ic-js library introduced the next-generation version of ICRC index canisters. The nns-dapp was using the old implementation until the new one was introduced in #6815, which added a new method. The goal is to migrate existing methods to the next-generation version and deprecate the old one from ic-js.

Changes

  • Migrate the getLedgerId API method to use the next-generation index canister.

Tests

  • Update getLedgerId tests to use mocks and spies for the next-generation canisters.
  • Refactor getTransactions tests to follow the same structure as the other tests.

Todos

  • Add an entry to the changelog (if necessary)
    Not necessary.

@yhabib yhabib marked this pull request as ready for review May 13, 2025 10:56
@yhabib yhabib requested a review from a team as a code owner May 13, 2025 10:56
mstrasinskis
mstrasinskis approved these changes May 15, 2025
View reviewed changes
Copy link
Contributor
@mstrasinskis mstrasinskis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yhabib yhabib added this pull request to the merge queue May 15, 2025
Merged via the queue into main with commit 89e3b57 May 15, 2025
36 checks passed
@yhabib yhabib deleted the yhabib/chore/migrate-ledger-endpoint-to-ng branch May 15, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstrasinskis mstrasinskis mstrasinskis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yhabib @mstrasinskis
0