Fix sns demo proposals creation #6722
10000
Jump to bottom
Open
+19
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhabib
reviewed
Apr 22, 2025
| }, | ||
| ] as [SnsAction], | ||
| }; | ||
| // const executeNSFunctionProposal = { |
There was a problem hiding this comment.
Is this block of code commented out because of the linter? What if we add a linter exception for the unused variable instead of commenting it?
| // The following proposals require specific state to be set up first. | ||
| executeNSFunctionProposal, | ||
|
|
||
| // Fails with error: 1 defects in Proposal: There is no NervousSystemFunction with id: 1002 |
There was a problem hiding this comment.
do you know why we get this error now?
There was a problem hiding this comment.
This proposal was failing before this PR. I assume the backend added stricter validation, which makes sense — proposals shouldn’t be allowed to execute non-existent NS-functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, creating dummy SNS proposals displays an error due to multiple failing calls.
This PR addresses a few related issues to make the flow work — except for
executeNSFunctionProposal, which is still failing.Proposals that would fail in the worst-case scenario before this PR (with reasons).
Most of the proposals fail because the neuron is locked during some proposals creation.
Changes
topic(errors 1-2).executeNSFunctionProposal(error 6) — solution still pending.Tests
Todos
Not necessary.