10000 feat: implement primitive for `ic0.root_key_`{`size`, `copy`} by Kamirus · Pull Request #4994 · dfinity/motoko · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: implement primitive for ic0.root_key_{size, copy} #4994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
May 27, 2025
Merged

feat: implement primitive for ic0.root_key_{size, copy} #4994

merged 11 commits into from
May 27, 2025

Conversation

Kamirus
Copy link
Contributor
@Kamirus Kamirus commented Apr 2, 2025 •
edited by ggreif
Loading

Depends-on #5148. Edit: unfortunately that is not sufficient, as dfinity/portal#5521 is not done yet. Watch dfinity/ic#4470!
ETA is last week of May...

Closes #4989.
Closes #4968.

@Kamirus Kamirus changed the title init implement primitive for ic0.root_key_{size, copy} Apr 2, 2025
ggreif
ggreif reviewed Apr 2, 2025
View reviewed changes
ggreif
ggreif reviewed Apr 2, 2025
View reviewed changes
ggreif
ggreif reviewed Apr 2, 2025
View reviewed changes
ggreif
ggreif reviewed Apr 2, 2025
View reviewed changes
Copy link
Contributor
@ggreif ggreif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far, thanks for jumping in!

@ggreif
Copy link
Contributor
ggreif commented Apr 2, 2025 •
edited
Loading

@Kamirus please do (cd test/run-drun && ../run.sh -ad upgrades.drun) and then git commit -a

Sadly make -C test/run-drun upgrades.accept won't work for .drun-style tests...

@ggreif ggreif changed the title implement primitive for ic0.root_key_{size, copy} feat: implement primitive for ic0.root_key_{size, copy} Apr 3, 2025
ggreif
ggreif reviewed May 23, 2025
View reviewed changes
ggreif
ggreif reviewed May 23, 2025
View reviewed changes
ggreif
ggreif reviewed May 23, 2025
View reviewed changes
ggreif
ggreif reviewed May 23, 2025
View reviewed changes
ggreif
ggreif reviewed May 23, 2025
View reviewed changes
@Kamirus Kamirus marked this pull request as ready for review May 27, 2025 15:24
@Kamirus Kamirus requested a review from a team as a code owner May 27, 2025 15:24
ggreif
ggreif approved these changes May 27, 2025
View reviewed changes
Copy link
Contributor
@ggreif ggreif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We were ahead of the time, but ic got us finally! :-)

@github-actions GitHub Actions
Copy link
github-actions bot commented May 27, 2025 •
edited
Loading

Comparing from c2a8a1c to 95cd085:
In terms of gas, no changes are observed in 5 tests.
In terms of size, 5 tests regressed and the mean change is +0.0%.

@Kamirus Kamirus merged commit fef9366 into master May 27, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggreif ggreif ggreif approved these changes

Assignees

@Kamirus Kamirus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

implement primitive for ic0.root_key_{size, copy} Implement getting the root key
2 participants
@Kamirus @ggreif
0