8000 feat(station): validate AllowListed and AllowListedByMetadata rules by olaszakos · Pull Request #570 · dfinity/orbit · GitHub

More Web Proxy on the site http://driver.im/

feat(station): validate AllowListed and AllowListedByMetadata rules #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

keplervital merged 12 commits into main from akos/tob-15

May 31, 2025

Contributor

olaszakos commented

This PR adds validations to make sure rules containing AllowListed and AllowListedByMetadata can only be applied to Transfer requests by:

adding specifier-rule compatibility check to RequestPolicy validation
adding validation to NamedRules to check if any policy directly or indirectly referencing the named rule is compatible with the rule


          feat(station): AllowListed and AllowListedByMetadata rules can only b…

6ffe4c3

…e applied to Transfers

olaszakos requested a review from a team as a code owner

May 12, 2025 14:30


          Merge branch 'main' into akos/tob-15

3d31766

mraszyk reviewed

View reviewed changes

core/station/impl/src/models/request_policy_rule.rs Outdated Show resolved Hide resolved

mraszyk reviewed

View reviewed changes

core/station/impl/src/models/request_policy_rule.rs Outdated Show resolved Hide resolved

mraszyk reviewed

View reviewed changes

core/station/impl/src/models/request_policy.rs Outdated Show resolved Hide resolved

mraszyk reviewed

View reviewed changes

core/station/impl/src/models/request_policy.rs Outdated Show resolved Hide resolved

mraszyk reviewed

View reviewed changes

core/station/impl/src/models/request_policy.rs Outdated Show resolved Hide resolved


          counterexample

430bd79

mraszyk reviewed

View reviewed changes

core/station/impl/src/models/named_rule.rs Outdated Show resolved Hide resolved

olaszakos added 3 commits

May 13, 2025 16:05


          traverse rules in validate_rule_for_specifier; add/fix tests;

f3e14ab


          implement traversing Display for RequestPolicyRule

e766793


          fix comment

f45f0d7

mraszyk reviewed

View reviewed changes

core/station/impl/src/errors/request_policy.rs Outdated Show resolved Hide resolved

mraszyk reviewed

View reviewed changes

core/station/impl/src/models/request_policy_rule.rs Outdated Show resolved Hide resolved

mraszyk reviewed

View reviewed changes

core/station/impl/src/models/request_policy.rs Show resolved Hide resolved

olaszakos added 4 commits

May 14, 2025 09:55


          simplify validate_policy_compatibility

630f441


          remove wildcard from _validate_rule_for_specifier

c433379


          improve error InvalidRuleForSpecifier

b9ac78b


          remove id after CIRCULAR_REFERENCE

9e3c409

keplervital approved these changes

View reviewed changes


          Merge branch 'main' into akos/tob-15

635a602

keplervital enabled auto-merge (squash)

May 30, 2025 13:54


          trigger ci

e8471ad

keplervital merged commit fcef293 into main

43 of 44 checks passed

keplervital deleted the akos/tob-15 branch

May 31, 2025 15:07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

0