feat(icrc): add method list subaccounts #906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
a1cde0e to
6385db0
Compare
This was referenced May 9, 2025
github-merge-queue bot
pushed a commit
to dfinity/nns-dapp
that referenced
this pull request
May 12, 2025
# Motivation We want to utilize the new function exposed by ic-js to [list subaccounts](dfinity/ic-js#906), enabling users to easily retrieve the list of all subaccounts for an ICRC canister. Note: This PR introduces a new canister object based on the NextGeneration Index canister. The existing one will be deprecated eventually, so a follow-up PR will migrate the existing methods to the new canister. [NNS1-3793](https://dfinity.atlassian.net/browse/NNS1-3793) # Changes - Add a new canister object for the Next Generation IndexCanister. - Add an API function to call `list_subaccounts`. # Tests - Add unit tests for the API function. # Todos - [ ] Add entry to changelog (if necessary). Not necessary. [NNS1-3793]: https://dfinity.atlassian.net/browse/NNS1-3793?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
mstrasinskis
added a commit
to dfinity/nns-dapp
that referenced
this pull request
May 12, 2025
commit e9a607b Author: Max Strasinsky <98811342+mstrasinskis@users.noreply.github.com> Date: Mon May 12 10:41:03 2025 +0200 feat(delegation-state-column): compareByVoteDelegation util (#6806) # Motivation To improve the overview of a user’s vote delegation state, it’s planned to display the delegation status icon directly in the neuron table by adding a new column: “Vote Delegation” (see screenshot). This PR adds a new util for sorting by vote delegation status. [Draft MVP PR](https://github.com/dfinity/nns-dapp/pull/6802/files) [Demo](https://qsgjb-riaaa-aaaaa-aaaga-cai.mstr-ingress.devenv.dfinity.network/) # Changes - Add compareByVoteDelegation util. # Tests - Added. # Todos - [ ] Add entry to changelog (if necessary). Not necessary. commit c428ef6 Author: Yusef Habib <yusef.fernandez@dfinity.org> Date: Mon May 12 10:32:04 2025 +0200 refactor(wallet): migrate SNS wallet to runes (#6807) # Motivation We aim to introduce changes to the `SnsWallet` component. This PR refactors the component using runes to simplify the addition of new features. [NNS1-3793](https://dfinity.atlassian.net/browse/NNS1-3793) # Changes - Refactor `SnsWallet` to use runes. # Tests - All tests should pass as before since no logical changes were made. # Todos - [ ] Add an entry to the changelog (if necessary). Not necessary. [NNS1-3793]: https://dfinity.atlassian.net/browse/NNS1-3793?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ commit 800b135 Author: Yusef Habib <yusef.fernandez@dfinity.org> Date: Mon May 12 08:12:15 2025 +0200 feat(portfolio): add alternative navigation controls to stacked cards (#6816) # Motivation The `StackedCards` component displays controls below the cards, allowing users to: 1. Identify their current card in the total. 2. Navigate between the cards. However, in scenarios with too many cards (projects), the dots may overflow. This PR introduces an alternative set of controls using buttons (previous and next) for card navigation. https://github.com/user-attachments/assets/cb4c518c-2f31-4d86-a4bf-73f74e1d6852 [NNS1-3641](https://dfinity.atlassian.net/browse/NNS1-3641) # Changes - Add alternative controls when there are too many cards. # Tests - Add a unit test for the new behavior. - Update existing tests to ensure that only one type of control is being rendered. - Tested in [devenv](https://qsgjb-riaaa-aaaaa-aaaga-cai.yhabib-ingress.devenv.dfinity.network/) # Todos - [ ] Add entry to changelog (if necessary). Not necessary [NNS1-3641]: https://dfinity.atlassian.net/browse/NNS1-3641?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ commit 83cdf18 Author: Yusef Habib <yusef.fernandez@dfinity.org> Date: Mon May 12 07:51:14 2025 +0200 feat(api): add new method listSubaccounts (#6815) # Motivation We want to utilize the new function exposed by ic-js to [list subaccounts](dfinity/ic-js#906), enabling users to easily retrieve the list of all subaccounts for an ICRC canister. Note: This PR introduces a new canister object based on the NextGeneration Index canister. The existing one will be deprecated eventually, so a follow-up PR will migrate the existing methods to the new canister. [NNS1-3793](https://dfinity.atlassian.net/browse/NNS1-3793) # Changes - Add a new canister object for the Next Generation IndexCanister. - Add an API function to call `list_subaccounts`. # Tests - Add unit tests for the API function. # Todos - [ ] Add entry to changelog (if necessary). Not necessary. [NNS1-3793]: https://dfinity.atlassian.net/browse/NNS1-3793?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ commit 03c1866 Author: Yusef Habib <yusef.fernandez@dfinity.org> Date: Mon May 12 07:51:07 2025 +0200 refactor(portfolio): migrate page component to runes (#6812) # Motivation We aim to display proposals for new SNS projects on the Portfolio page that were approved before the swap begins. This PR prepares the Portfolio page to introduce the pre-swap cards by migrating to runes. [NNS1-3639](https://dfinity.atlassian.net/browse/NNS1-3639) # Changes - Refactored the page to use runes. # Tests - Tests should pass as before since there were no logical changes. # Todos - [ ] Add an entry to the changelog (if necessary) Not necessary. [NNS1-3639]: https://dfinity.atlassian.net/browse/NNS1-3639?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ commit cf918b6 Author: pr-automation-bot-public[bot] <189003650+pr-automation-bot-public[bot]@users.noreply.github.com> Date: Sun May 11 11:22:58 2025 +0200 bot: Update IC Cargo Dependencies to release-2025-05-08_03-21-base (#6817) # Motivation A newer release of the internet computer is available. We want to keep our Cargo dependencies up to date. # Changes * Ran `scripts/update-ic-cargo-deps` to update the Cargo.toml dependencies to the latest IC release. # Tests * See CI Co-authored-by: gix-bot <gix-bot@users.noreply.github.com> commit 81d3e7a Author: Yusef Habib <yusef.fernandez@dfinity.org> Date: Fri May 9 15:36:36 2025 +0200 feat(portfolio): implement pre-swap SNS proposal card (#6811) # Motivation We want to display proposals for new SNS projects on the Portfolio page that were approved before the swap begins. This first PR introduces a new type of card for these cases. Note: There are some deviations from the design: there is no project link, as it is not always available, and we will reuse the same remaining time format as the other cards. Design:  Implementation:  [NNS1-3639](https://dfinity.atlassian.net/browse/NNS1-3639) # Changes - New `AdoptedProposalCard` component. # Tests - Unit tests for the new component. # Todos - [ ] Add entry to changelog (if necessary). Not necessary. [NNS1-3639]: https://dfinity.atlassian.net/browse/NNS1-3639?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We aim to introduce a new method, listSubaccounts, in the
IcrcIndexNgCanisterclass.Changes
listSubaccountsmethod to theIcrcIndexNgCanisterclass.Tests
Todos