8000 feat: extend transform for provisional_create_canister_with_cycles by peterpeterparker · Pull Request #796 · dfinity/ic-js · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: extend transform for provisional_create_canister_with_cycles #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat: extend transform for provisional_create_canister_with_cycles #796

wants to merge 10 commits into from

Conversation

peterpeterparker
Copy link
Member
@peterpeterparker peterpeterparker commented Dec 20, 2024 •
edited
Loading

Motivation

In order to install canister in development with PocketIC the transform function should be extended to intercept provisional_create_can 8000 ister_with_cycles and potential specified_id.

Reference

https://internetcomputer.org/docs/references/ic-interface-spec#http-effective-canister-id

Changes

  • Add support for provisional_create_canister_with_cycles and optional specifiedId to transform utils.

@peterpeterparker
feat: extend transform for provisional_create_canister_with_cycles
e2a1543 
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Dec 20, 2024 •
edited
Loading

size-limit report 📦

Path Size
@dfinity/ckbtc 8.16 KB (0%)
@dfinity/cketh 3.7 KB (0%)
@dfinity/cmc 1.39 KB (0%)
@dfinity/ledger-icrc 4.36 KB (0%)
@dfinity/ledger-icp 15.43 KB (0%)
@dfinity/nns 37.59 KB (0%)
@dfinity/nns-proto 140.99 KB (0%)
@dfinity/sns 18 KB (0%)
@dfinity/utils 5.06 KB (0%)
@dfinity/zod-schemas 626 B (0%)
@dfinity/ic-management 3.32 KB (+0.95% 🔺)

peterpeterparker and others added 9 commits December 20, 2024 13:18
@peterpeterparker
feat: specified_id is optional
0d0b55c 
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@peterpeterparker
chore: merge main
454e3c3 
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@peterpeterparker
chore: fmt
444a856 
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@github-actions
Updating formatting
c2d7898
@peterpeterparker
test: transform specified_id
bf0cfe7 
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@peterpeterparker
Merge remote-tracking branch 'origin/feat/provisional_create_canister…
cd3f664 
…_with_cycles' into feat/provisional_create_canister_with_cycles
@peterpeterparker
feat: improve code and test
88e9a63 
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@peterpeterparker
docs: change
876a6a6 
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@github-actions
Updating formatting
10a4c79
@peterpeterparker peterpeterparker marked this pull request as ready for review May 21, 2025 15:15
@peterpeterparker peterpeterparker requested review from a team as code owners May 21, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@peterpeterparker
0