feat(cli): refine '--help' handling in propose command #1363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Key Changes - **Disable Automatic Help Flag Parsing:** - Added `#[clap(disable_help_flag = true)]` to `Propose` struct to manually handle `--help`. - **Manual Help Handling:** - Updated the `execute` method in the `Propose` command to call `ctx.help_propose(None)` when `--help` is detected. - **Modify Submission Parameters:** - Enabled dry-run mode if `--help` is present to bypass unnecessary interactive prompts. - **Access Control Adjustment:** - Changed `dry_run` in `ConfirmationModeOptions` from private to `pub(crate)` to support manual help handling. - **Documentation and Comments:** - Updated comments to explain the manual handling of the `--help` flag and its effect on submission parameters.
pietrodimarco-dfinity
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements
Proposestruct, disabling automatic flag parsing to manage propose subcommands.