feat(didc-js): encode and validate specific types and service args #602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christoph-dfinity
requested changes
Apr 29, 2025
There was a problem hiding this comment.
As discussed the general approach here looks reasonable. Just have a couple suggestions/requests regarding the Rust code.
I tried to run the tests in tools/didc-js after installing pnpm, but am getting the following error. Do you know what I'm doing wrong here?
EDIT: Seems like the sequence is pnpm run build && pnpm run test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR extends the
didc-jswasm module with capability to encode values of specific types, and values for the service arguments, with the purpose of also validating them against those types. This is useful for JS clients where the user is expected to produce valid candid value for a particular type.Requirements
encodefunction can receive type information other thanservice_methodsuch as a type name or instruction to use the service argument typesConsidered Solutions
I did not find any other solution.
Recommended Solution
Since
encodealready has this functionality to encode (and validate) service method arguments, this seems like a good place to extend the functionality.Considerations