add icons and change devicon json #292
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
can someone look at the devicon json before we merge to make sure its all good?
amacado
requested changes
Sep 22, 2020
There was a problem hiding this comment.
Hello @Jessycah and welcome! :) You sadly have created your pull request based on the branch upgrade-devicon which we're not using for creating new icons. Please checkout master or develop branch (which we are currently working on) to add a new icon.
Please take a look at our CONTRIBUTING.md where all requirements about a new icon are listed. F.e. make please make sure:
- Each icon has his own folder located in the "icons" folder
- Modify devicon-colors.css to include the colored version of the icon
- Each .svg file contains one version of an icon in a "0 0 128 128" viewbox
- At least the plain or line version of the icon is required (since those are required for the icon font)
...
Since there are many things todo before this pull request is ready for merge I will close it for now. Feel free to reopen it again once your request is ready! :)
| @@ -1,4 +1,13 @@ | |||
| [ | |||
| { | |||
| "name": "jenkins", | |||
| "_comment1": "Add Jenkins icon please, I don't know if the things below are ok: I also added the png format, alongside with svg format", | |||
There was a problem hiding this comment.
Suggested change
| "_comment1": "Add Jenkins icon please, I don't know if the things below are ok: I also added the png format, alongside with svg format", |
This _comment1 is not required nor valid in devicon.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
can someone look at the devicon json before we merge to make sure its all good?