8000 new icon: LabVIEW (original, plain, original-wordmark, plain-wordmark) by mjlabe · Pull Request #283 · devicons/devicon · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

new icon: LabVIEW (original, plain, original-wordmark, plain-wordmark) #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mjlabe
Copy link
Contributor
@mjlabe mjlabe commented Sep 6, 2020

LabVIEW icon from PR #136

labview-original-wordmark
labview-original
labview-plain-wordmark
labview-plain

@amacado amacado added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Sep 6, 2020
@amacado
Copy link
Member
amacado commented Sep 7, 2020

Hello @mjlabe thanks for this contribution! I tried to google for LabView logo/icon but could not find the design you provided. Is this your own creation/adaption?

@mjlabe
Copy link
Contributor Author
mjlabe commented Sep 7, 2020

Sort of. I've used it for years and the logo changes a bit over time. It started as:

https://blog.digilentinc.com/wp-content/uploads/2017/02/labview_logo-e1486411393153.png

And moved to this:

https://labviewwiki.org/w/images/thumb/2/2d/LV2019.png/256px-LV2019.png

But my non-wordmark version is this:

https://yt3.ggpht.com/-T6wZgUnViz0/AAAAAAAAAAI/AAAAAAAAAAA/4jmqj1FlGY4/s900-c-k-no-mo-rj-c0xffffff/photo.jpg

And my wordmark version is a combo of both.

You can also find the designs on their website here:

https://www.ni.com/en-us/shop/labview.html

@amacado amacado changed the base branch from master to develop October 9, 2020 17:04
@Thomas-Boi
Copy link
Member

Hello there,
Recently, we just introduced an automation pipeline to Devicon which will help us create the icons. Before we can merge your changes in, there are a few things that we need to do first:

  1. Merge the current devicon/develop branch into your PR branch. This contains the build script needed for us to build your icons.
  2. Read the CONTRIBUTING.md for things to do before merging and review our icon standards.
  3. Push your changes and/or branches. We will review them once this is done and merge your PR if everything goes well.

Thank you for contributing to this repo. We are sorry that we haven't accept any PR for awhile. Now that we have a build pipeline, we can merge PRs more quickly than before.

We hope to see your icons in the Devicon repo soon :)

Cheers,
Devicon Team

@Thomas-Boi
Copy link
Member

Hello there,

We notice that this PR has been inactive for awhile now. It would be a waste of your time and effort if we just close this PR and throw away the SVGs in here. Thus, 1 month from now, if this PR remains inactive/stale, we will fork your repo, fix any issues, and merge your icons ourselves.

Since GitHub tracks contributions by commits, you will still be credited. We also hope that you will help us merge this PR before the deadline comes.

Cheers,
Devicon Team

@Thomas-Boi Thomas-Boi added the stale For PRs that haven't had any activity for a while and old issues label Jan 6, 2021
@amacado amacado linked an issue May 2, 2021 that may be closed by this pull request
@Thomas-Boi
Copy link
Member

Hi @mjlabe,

I'm working on merging your PR to accept your icon. However, it seems like your branch is a bit out of date. It'd be much appreciated if you can bring the branch up to date with develop and re-push.

After a week, if the branch hasn't been updated I'll make a new PR cherry-picking your commit. This is to ensure you are still the author of the commit and get proper credits. You can also just give me permission to do it this way now.

It'd be quicker if you update the branch yourself though but whichever works 👍

@Thomas-Boi
Copy link
Member

I just changed the colors in your icons so it matches the ones found in the last 5 years. You can see the icon here. You can view the new PR at #626

@Thomas-Boi Thomas-Boi closed this May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection stale For PRs that haven't had any activity for a while and old issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon request: LabVIEW
3 participants
0