-
Notifications
You must be signed in to change notification settings - Fork 2.4k
new icon: LabVIEW (original, plain, original-wordmark, plain-wordmark) #283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello @mjlabe thanks for this contribution! I tried to google for LabView logo/icon but could not find the design you provided. Is this your own creation/adaption? |
Sort of. I've used it for years and the logo changes a bit over time. It started as: https://blog.digilentinc.com/wp-content/uploads/2017/02/labview_logo-e1486411393153.png And moved to this: https://labviewwiki.org/w/images/thumb/2/2d/LV2019.png/256px-LV2019.png But my non-wordmark version is this: And my wordmark version is a combo of both. You can also find the designs on their website here: |
Hello there,
Thank you for contributing to this repo. We are sorry that we haven't accept any PR for awhile. Now that we have a build pipeline, we can merge PRs more quickly than before. We hope to see your icons in the Devicon repo soon :) Cheers, |
Hello there, We notice that this PR has been inactive for awhile now. It would be a waste of your time and effort if we just close this PR and throw away the SVGs in here. Thus, 1 month from now, if this PR remains inactive/stale, we will fork your repo, fix any issues, and merge your icons ourselves. Since GitHub tracks contributions by commits, you will still be credited. We also hope that you will help us merge this PR before the deadline comes. Cheers, |
Hi @mjlabe, I'm working on merging your PR to accept your icon. However, it seems like your branch is a bit out of date. It'd be much appreciated if you can bring the branch up to date with develop and re-push. After a week, if the branch hasn't been updated I'll make a new PR cherry-picking your commit. This is to ensure you are still the author of the commit and get proper credits. You can also just give me permission to do it this way now. It'd be quicker if you update the branch yourself though but whichever works 👍 |
LabVIEW icon from PR #136