8000 Added Knockout icon (plain-workmark only) by aueda · Pull Request #90 · devicons/devicon · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Added Knockout icon (plain-workmark only) #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Added Knockout icon (plain-workmark only) #90

wants to merge 1 commit into from

Conversation

aueda
Copy link
Contributor
@aueda aueda commented Nov 16, 2017

No description provided.

@amacado amacado added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Jun 8, 2020
amacado
amacado requested changes Jun 11, 2020
View reviewed changes
Copy link
Member
@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. Please take a look at our updated contribution guidelines and pay special attention to:

  • Modify devicon.json to include the icon (or variations)
  • Modify devicon-colors.css to include the colored version of the icon

@Thomas-Boi
Copy link
Member

Hello there,
Recently, we just introduced an automation pipeline to Devicon which will help us create the icons. Before we can merge your changes in, there are a few things that we need to do first:

  1. Merge the current devicon/develop branch into your PR branch. This contains the build script needed for us to build your icons.
  2. Read the CONTRIBUTING.md for things to do before merging and review our icon standards.
  3. Push your changes and/or branches. We will review them once this is done and merge your PR if everything goes well.

Thank you for contributing to this repo. We are sorry that we haven't accept any PR for awhile. Now that we have a build pipeline, we can merge PRs more quickly than before.

We hope to see your icons in the Devicon repo soon :)

Cheers,
Devicon Team

@Thomas-Boi
Copy link
Member

Hello there,

We notice that this PR has been inactive for awhile now. It would be a waste of your time and effort if we just close this PR and throw away the SVGs in here. Thus, 1 month from now, if this PR remains inactive/stale, we will fork your repo, fix any issues, and merge your icons ourselves.

Since GitHub tracks contributions by commits, you will still be credited. We also hope that you will help us merge this PR before the deadline comes.

Cheers,
Devicon Team

@Thomas-Boi Thomas-Boi added the stale For PRs that haven't had any activity for a while and old issues label Jan 6, 2021
@Thomas-Boi
Copy link
Member

Hi @aueda, are you still planning to work on this PR or should I take over? I can help guide you through our commit process as well since it has changed quite a bit.

@Thomas-Boi Thomas-Boi mentioned this pull request May 25, 2021
Merged
@Thomas-Boi
Copy link
Member

Hi @aueda, you can view the new PR for this icon at #628. Thank you for your icon 👍

@Thomas-Boi Thomas-Boi closed this May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amacado amacado amacado requested changes

Assignees

@aueda aueda

Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection stale For PRs that haven't had any activity for a while and old issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aueda @Thomas-Boi @amacado
0