Refactor codebase for Python 3 compatibility #11

CodeBreaker44 · 2024-12-22T18:33:55Z

Updated syntax (e.g., print function, etc.).
Replaced obsolete libraries or functions with Python 3 equivalents.
Updated dependencies to versions compatible with Python 3.

Acters · 2024-12-23T08:43:16Z

This does not work because you did not update rom.py and address.py properly.

In the rom.py, the Rom class function get(self, addr) makes a function call to struct.unpack that which will expect self.data[addr.physical()] to be the type bytes and will throw an error. I found that it is fine to do this dirty trick to quickly get it to work:

    def get(self, addr):
        return struct.unpack('B', (self.data[addr.physical()]).to_bytes(1,"little") if type(self.data[addr.physical()]) == int else self.data[addr.physical()])[0]

however, then in the address.py file, the following error will occur:

    if ":" not in conventional:
       ^^^^^^^^^^^^^^^^^^^^^^^
TypeError: a bytes-like object is required, not 'str'

I am unsure what causes this, but another dirty trick of adding this into the function would be fine enough for my current ROM:

def fromConventional(conventional):
    if type(conventional) == bytes:
        conventional = conventional.decode()

I know I randomly showed up, but I was looking at a ROM and gave this a shot. I don't have much to provide in help, but this worked for me, so far. I haven't tried all the features but I do notice there is also a problem with the server.py as it writes to the socket and it will error because writing to the socket expects bytes. which means the strings need to be encoded or designated with b""

I notice you made this PR recently, but the author didnt update it in more than a decade. looks like it will not be merged, but thank you for making the PR either way.

code refactor to wotk with python3

68ae5e6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor codebase for Python 3 compatibility #11

Refactor codebase for Python 3 compatibility #11

Refactor codebase for Python 3 compatibility #11

Are you sure you want to change the base?

Refactor codebase for Python 3 compatibility #11

Conversation