8000 Refactor ReturnFromFinally with the analysis api by inorichi · Pull Request #8217 · detekt/detekt · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Refactor ReturnFromFinally with the analysis api #8217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactor ReturnFromFinally with the analysis api #8217

wants to merge 1 commit into from
+20 −19

Conversation

inorichi
Copy link

This PR refactors the ReturnFromFinally rule to use the Analysis API as part of #8042

@detekt-ci
Copy link
Collaborator
detekt-ci commented Jun 27, 2025 •
edited
Loading
Warnings
⚠️ It looks like this PR contains functional changes without a corresponding test.

Generated by 🚫 dangerJS against 482b5d5

@inorichi inorichi force-pushed the refactor/8042_returnfromfinally branch from bf50927 to 482b5d5 Compare June 27, 2025 09:48
@codecov Codecov
Copy link
codecov bot commented Jun 27, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.96%. Comparing base (9788ceb) to head (482b5d5).

Files with missing lines Patch % Lines
...bosch/detekt/rules/exceptions/ReturnFromFinally.kt 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #8217   +/-   ##
=========================================
  Coverage     84.95%   84.96%           
  Complexity     4266     4266           
=========================================
  Files           573      573           
  Lines         13599    13600    +1     
  Branches       2543     2542    -1     
=========================================
+ Hits          11553    11555    +2     
+ Misses          840      839    -1     
  Partials       1206     1206

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BraisGabin BraisGabin BraisGabin approved these changes

Assignees
No one assigned
Labels
rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@inorichi @detekt-ci @BraisGabin
0